-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs with Timespan#getAs #6909
Fix bugs with Timespan#getAs #6909
Conversation
…ing as int max value. Fix bug where millis was multiplied instead of divided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 213 needs the Javadoc fixed aswell
-@deprecated Use {@link Timespan#Timespan(TimePeriod, long)}
+@deprecated Use {@link #Timespan(TimePeriod, long)}
Is this an issue? Seems fine either way to me. |
There is no subclass called |
Seems like an issue with those extensions, then, because it's valid in java docs specifications. |
Applying my suggestion solves the issue for IDE's and the Javadoc |
I can make the change but you should probably report that as a bug and/or get a better extension/IDE, since it displays fine on intellij too |
Description
Remove rounding from getAs (it should truncate anyway) to avoid limiting as int max value. Fix bug where millis was multiplied instead of divided.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6908